Re: [PATCH] : rework checks handling

Krzysztof,

That's excellent work, thank you! I'm going to merge after a few basic checks here since you said you could not. But I'm confident, code looks OK.

I just have one comment about the doc. While I don't care about the 80 col limit in the code, this time I *do* really want to ensure that we never cross this limit. That way we know we can print the doc using a2ps or things like this without missing even one char. I've noticed one or two long lines, I'll merge your patch and quickly adjust the doc in the next patch.

At first glance, here are the few victims which will have their tail cut :

> + See also: "timeout connect", "timeout queue", "timeout server", "timeout tarpit".
> + See also: "timeout check", "timeout queue", "timeout server", "timeout tarpit" "contimeout".
> + Just as with every other time-based parameter, they can be entered in any other

Best regards,
Willy Received on 2008/01/21 22:15