Re: [PATCH] : Restore clearing t->logs.bytes

Hi Krzysztof,

On Mon, Jan 21, 2008 at 01:58:23AM +0100, Krzysztof Oledzki wrote:
> >From 228127bcd843d9d9f354eeee6f164941a9d41343 Mon Sep 17 00:00:00 2001
> From: Krzysztof Piotr Oledzki <ole#ans.pl>
> Date: Sun, 20 Jan 2008 23:27:02 +0100
> Subject: [BUG]: Restore clearing t->logs.bytes
>
> Commit 8b3977ffe36190e45fb974bf813bfbd935ac99a1 removed "t->logs.bytes_in = 0;"
> but instead it should change it into "t->logs.bytes_out = 0;" as since
> 583bc966064e248771e75c253dddec7351afd8a2 counters are incremented not set.
> We need this to prevent counting headers twice.

Are you really sure ? I thought it was a reminiscent of bytes -> bytes_in changes because I failed to find in what case it may be used.

From what I see, it's only used if we want to log early (logasap). In this case, it looks like we set bytes_out to the header size to make it appear in the logs and then set it back to zero. But stupid question is how then you we account for this size ?

If it's really needed, then we need to add a comment next to it. The first time I saw it, I thought it was really a bug due to the fact it is assigned above. In fact, the comment should even be added at the first assignment, stating that it is temporary.

I'd like your opinion on this.

Thanks,
Willy Received on 2008/01/21 22:01