Re: [PATCH v2] *_dom matching header functions now also split on ":"

From: Finn Arne Gangstad <finnag#pvv.org>
Date: Sat, 10 Sep 2011 09:59:46 +0200


On Fri, Sep 09, 2011 at 09:03:15PM +0200, Willy Tarreau wrote:
> Hi Finn,
>
> Yes, thanks for the update, I noticed this too and fixed it during
> tests. I'm OK with this method. I have just replaced the macros with
> inline functions (which I verified produced the same code) because
> the result is more readable. And I removed the typedef, as I consider
> that typedefs for scalars just add obfuscation, but I know it's a
> matter of taste.
>
> I'm about to merge the attached patch, unless you raise your hand in
> a very short time ;-)

Thanks, it's much nicer like this! The typedef was only there to support the two different macro versions since they needed different types in the delimiter.

Received on 2011/09/10 09:59

This archive was generated by hypermail 2.2.0 : 2011/09/10 10:15 CEST