Re: "timeout client" weird behaviour in 1.3.22

On Thu, Apr 15, 2010 at 12:00:46PM +0200, Cyril Bouthors wrote:
> On 15 Apr 2010, w#1wt.eu wrote:
>
> > Indeed, but it can happen due to defaults sections. In 1.4.4, you'd get a
> > warning and the option would be disabled anyway. I'll check in 1.3 if it's
> > worth adding such tests, but I don't want to discourage 1.3 users from
> > updating their version due to invasive warnings, and I will not release a
> > version with just that. So maybe we'll add a few silent ignores in the
> > config parser if it happens to be worth it.
>
> I think it might be a better idea to warn the user only if he/she
> explicitly define 'option forceclose' in a 'mode tcp' section.
>
> If it's in the default, haproxy just need to disable it.

It's not that easy. We only know about an option setting once the whole section is parsed, and we don't know if it was explicitly set or inherited from the defaults section. Also, I generally prefer to warn users about dangerous option combinations than let them believe their option has any effect.

Regards,
Willy Received on 2010/04/15 12:16