Re: [PATCH] BUG] config: fix erroneous check on cookie domain names, again

On Tue, Dec 15, 2009 at 11:42:14PM +0100, Krzysztof Piotr Oledzki wrote:
> >From 79b9d25eb78cb217b0a8fe90d33f14061db2a767 Mon Sep 17 00:00:00 2001
> From: Krzysztof Piotr Oledzki <ole#ans.pl>
> Date: Tue, 15 Dec 2009 23:40:47 +0100
> Subject: BUG] config: fix erroneous check on cookie domain names, again
>
> The previous check was correct: the RFC states that it is required
> to have a domain-name which contained a dot AND began with a dot.
> However, currently some (all?) browsers do not obey this specification,
> so such configuration might work.
>
> This patch reverts 3d8fbb6658d4414dac20892bbd9e79e14e99e67f but
> changes the check from FATAL to WARNING and extends the message.

OK but do you mind if I replace the Alert below with a Warning ? Warnings are typically used for border-line configurations that may or may not work. Alerts are used to indicate an imminent failure before starting up.

Regards,
Willy Received on 2009/12/16 00:06