Re: [PATCH] proto_uxst rework -> SNMP support

On Fri, Feb 29, 2008 at 12:04:39PM +0100, Krzysztof Oledzki wrote:
>
>
> On Thu, 28 Feb 2008, Willy Tarreau wrote:
>
> >On Wed, Feb 27, 2008 at 06:07:32PM +0100, Krzysztof Oledzki wrote:
> >>OK. I'll send a new version of this patch with the perl code moved to the
> >>contrib/netsnmp-perl directory. I'll also implement snmpwalk and change
> >>the order of parameters in oids as my colleagues suggested me that it
> >>should be grouped in a different way, so oids can be easily imported in
> >>Cacti.
> >
> >OK. I feel better now that I can slowly catch up with all your work :-)
> >I've tried your first patch and it looks cool. BTW, you should take a look,
> >in the doc and in the commit you wrote "show stats" while it is "show
> >stat".
>
> Oh, sorry. It was quite late when I did the job, I'll try to be more
> carefull next time.

no problem, you know.

> >So now I'm waiting for your replacement patch. By that time, I'll see if
> >I can fix the instances numbering. I'm not touching the 16 kB limit so
> >that I do not conflict with your later patch for stats.
>
> OK. I think I'll need one more day so it should be ready tomorrow as I
> would like to finish snmp support for "show info" and add xmls for Cacti.

fine.

> Could you push current commits so I'll make sure there are no conflicts?

yes, I had a network outage yesterday evening which prevented me from uploading the changes. that's done now.

> BTW: there is one more unhandled patch: "Prevent redispatcher from
> selecting the same server, version #3". ;)

OK, I had some confusion initially about this one because I thought it changed the behaviour to what you described in the second part of the changelog, which it apparently does not. I'll merge it.

Thanks,
willy Received on 2008/02/29 12:13