Re: [PATCH] : Prevent redispatcher from selecting the same server

On Tue, Feb 05, 2008 at 09:46:42PM +0100, Krzysztof Oledzki wrote:
>
>
> On Mon, 4 Feb 2008, Krzysztof Oledzki wrote:
>
> >From 7ece40b892a91f0d7fc673b6e5977766ab3e047b Mon Sep 17 00:00:00 2001
> >From: Krzysztof Piotr Oledzki <ole#ans.pl>
> >Date: Sun, 3 Feb 2008 23:44:44 +0100
> >Subject: [MAJOR]: Prevent redispatcher from selecting the same server
> >
> >When haproxy decides that session needs to be redispatched it chose a
> >server,
> >but there is no guarantee for it to be a different than the current one.
> >So,
> >it often happens that selected server is exactly the same that it was
> >previously and client ends up with a 503 error anyway, especially when one
> >sever has much bigger weight than others.
> >
> >This patch fixes FWRR and RR algos. It also delays SN_DIRECT/SN_REDISP
> >operations and http_flush_cookie_flags call so they are executed only when
> >a connection was truly redispatched not only intended to.
>
> Ping? Overlook or needs more time to be audited?

Well caught! I read it but let the mail marked "read" and did not notice it afterwards. I'll merge it too. I've not read the other ones yet, I'll work on that when I settle down (most likely this week-end).

Regards,
Willy Received on 2008/02/07 21:28