Re: [PATCH] Implement and use generic findproxy and relax duplicated proxy check

On Sat, Nov 03, 2007 at 02:03:12AM +0100, Krzysztof Oledzki wrote:
>
>
> On Fri, 2 Nov 2007, Krzysztof Oledzki wrote:
>
> >From f001dd9963f3bd320bc022287ce348970d190e3c Mon Sep 17 00:00:00 2001
> >From: Krzysztof Piotr Oledzki <ole#ans.pl>
> >Date: Fri, 2 Nov 2007 17:07:15 +0100
> >Subject: [MEDIUM] Implement and use generic findproxy and relax duplicated
> >proxy check
>
> <CUT>
>
> Please do not apply this patch. Found two things I should fix:
>
> >+ Alert("You man want to use 'mode %s'.\n",
> >proxy_mode_str(mode));
> s/man/may/
>
> >+ if (!target)
> >+ Alert("Proxy '%s' with backend capability was not found!\n",
> >name);
> Useless and wrong, should be removed.

OK.

> Anything more to fix?

No, at first glance, the patch looks OK.

Cheers,
Willy Received on 2007/11/03 07:32