Re: PATCH: Was: Re: Timed cookies

On Mon, 22 Oct 2007, Krzysztof Oledzki wrote:

>
>
> On Mon, 22 Oct 2007, Willy Tarreau wrote:
>
>> On Mon, Oct 22, 2007 at 07:52:41PM +0200, Krzysztof Oledzki wrote:
>>>> After a quick review, your patch looks perfect to me. I'll merge it.
>>> Thank you.
>>
>> OK I've merged your patch.
>
> Thanks.
>
>> However, just FYI, I don't know if you have transferred it via a windows
>> machine, but it was corrupted, there were ^M at the end of all lines. At
>> first I was amazed by so many rejects :-)
>
> Frankly, I have no idea how did it happen. I will try to investigate this,
> very strange. Sorry about that.

It seems that my mailer (pine) changes endlines to crlf of all attached text files. I checked and it had done the same thing with my previous mails. Hopefully it converts it back to the unix endline format when I save them and that is why I never noticed it before.

Just found this (http://freshmeat.net/projects/pine/):

• cut here ---
  > Pine has a very annoying feature-bug. Text files
  > attached in Pine are converted to the DOS line
  > endings. Pine converts the test back to UNIX
  > style, but other mail clients don't. <...>
  > Why on earth should patches to UNIX
  > programs (that no DOS user will ever need) be
  > transferred as encoded files with DOS line endings?
  I do not use Pine (I'm author of other mail client), but that conversion is requirement of MIME. MIME says that canonical encoing of text is CRLF endings of lines, so base64 text data must have converted to CRLF ending before encoding it if it is send as Text/* type. So what is that "other mail clients" what you are refering ? (Assuming that PINE labels attachment with type Text/...)

Basically almost all Internet standards use CRLF as line ending for text data... :-)
--- cut here ---

Not sure what I can do with this in the future. I can gzip patches before sending but this makes review more complicated.

Best regards,

                                 Krzysztof Olêdzki Received on 2007/10/22 23:29