Re: PATCH: Was: Re: Timed cookies

On Mon, 22 Oct 2007, Willy Tarreau wrote:

> [ I removed John from the CC, he might not be interested in receiving
> off-topic junk in his mailbox ]
>
> On Mon, Oct 22, 2007 at 07:52:41PM +0200, Krzysztof Oledzki wrote:
>>> BTW, since you're using GIT too, I don't know if you already know it,
>>> but it's easy to regenerate a complete patch this way, assuming you
>>> have the official tree in the "mainline" branch, and your changes in
>>> the "mine" branch :
>>>
>>> $ git-format-patch -k -m mainline..mine
>>>
>>> It will create one file per patch, with the description, author, date,
>>> and subject, along with the references to the ancestor. This is very
>>> convenient. I even use this inside my own branches to rearrange and
>>> combine changes by functional associations before merging them in
>>> "master".
>>
>> I did not know about this, thanks.
>
> There is also "git show <commit id>" which immediately shows your desc
> and patch. Very handy too for a last review before posting.

Yes. This is one of my most favorite commands. ;)

>> However, as I mentioned before, I have some problems cloning the
>> repository. :(
>
> Still??? Grrr. That's getting boring. I saw a host from .pl cloning
> the rep a few days ago, and I thought it was finally OK. The problem
> with git-clone is that if you have *one* error, it aborts and removes
> everything you have downloaded.

Exactly. :(

> I have repacked the repository so that there's only one 1.3 MB file
> to download. It should significantly reduce the risk of failure.
> Could you please retry ? It should take about 2 minutes on my 128 kbps
> line.
>
> If it still fails, I'll provide a tar of the git repo on my site as
> a starting point. But that should definitely not be required :-(

OK, there were no problems this time. Thank you.

Best regards,

                                 Krzysztof Olêdzki Received on 2007/10/22 21:46