Re: Count retries and redispatches

Hi Krzysztof,

On Sun, Sep 23, 2007 at 03:29:21PM +0200, Krzysztof Oledzki wrote:
> Hello,
>
> It is important to know how does your instalation perform. Haproxy masks
> connection errors, which is extremely good for a client but it is bad for
> an administrator (except people believing that "ignorance is a bless").
>
> Attached patch adds retries and redispatches counters, so now haproxy:
>
> 1. For server:
> - counts retried connections (masked or not)
>
> 2. For backends:
> - counts retried connections (masked or not) that happened to
> a slave server
> - counts redispatched connections
> - does not count successfully redispatched connections as backend errors.
> Errors are increased only when client does not get a valid response,
> in other words: with failed redispatch or when this function is not
> enabled.
>
> 3. For statistics:
> - display Retr (retries) and Redis (redispatches) as a "Warning"
> information.
>
> I think it is a post-1.3.12 material.

I've merged your work in 1.3.13, along with a very minor fix : the backend's retries was not increased when srv->retries was increased. I'll most likely release 1.3.13 with all that this evening.

Thanks!
Willy Received on 2007/10/18 19:14